improve-performance-of-office-data-import (#83)

Co-authored-by: Michael Hoennig <michael@hoennig.de>
Reviewed-on: https://dev.hostsharing.net/hostsharing/hs.hsadmin.ng/pulls/83
Reviewed-by: Marc Sandlus <marc.sandlus@hostsharing.net>

src/main/resources/db/changelog/1-rbac/1058-rbac-generators.sql

@@ -178,6 +178,8 @@ begin
         create or replace view %1$s_rv as
             with accessible_%1$s_uuids as (
 
+                -- TODO.perf: this CTE query makes RBAC-SELECT-permission-queries so slow (~500ms), any idea how to optimize?
+                --  My guess is, that the depth of role-grants causes the problem.
                 with recursive grants as (
                     select descendantUuid, ascendantUuid, 1 as level
                         from RbacGrants
@@ -197,8 +199,7 @@ begin
                     from granted
                              join RbacPermission perm on granted.descendantUuid = perm.uuid
                              join RbacObject obj on obj.uuid = perm.objectUuid
-                    where perm.op = 'SELECT'
-                      and obj.objectTable = '%1$s'
+                    where obj.objectTable = '%1$s' -- 'SELECT' permission is included in all other permissions
                     limit 8001
             )
             select target.*

src/main/resources/db/changelog/2-test/201-test-customer/2013-test-customer-rbac.sql

@@ -142,8 +142,8 @@ begin
         return NEW;
     end if;
 
-    raise exception '[403] insert into test_customer not allowed for current subjects % (%)',
-            currentSubjects(), currentSubjectsUuids();
+    raise exception '[403] insert into test_customer values(%) not allowed for current subjects % (%)',
+            NEW, currentSubjects(), currentSubjectsUuids();
 end; $$;
 
 create trigger test_customer_insert_permission_check_tg

src/main/resources/db/changelog/2-test/202-test-package/2023-test-package-rbac.sql

@@ -207,8 +207,8 @@ begin
         return NEW;
     end if;
 
-    raise exception '[403] insert into test_package not allowed for current subjects % (%)',
-            currentSubjects(), currentSubjectsUuids();
+    raise exception '[403] insert into test_package values(%) not allowed for current subjects % (%)',
+            NEW, currentSubjects(), currentSubjectsUuids();
 end; $$;
 
 create trigger test_package_insert_permission_check_tg

src/main/resources/db/changelog/2-test/203-test-domain/2033-test-domain-rbac.sql

@@ -206,8 +206,8 @@ begin
         return NEW;
     end if;
 
-    raise exception '[403] insert into test_domain not allowed for current subjects % (%)',
-            currentSubjects(), currentSubjectsUuids();
+    raise exception '[403] insert into test_domain values(%) not allowed for current subjects % (%)',
+            NEW, currentSubjects(), currentSubjectsUuids();
 end; $$;
 
 create trigger test_domain_insert_permission_check_tg

src/main/resources/db/changelog/5-hs-office/504-partner/5043-hs-office-partner-rbac.sql

@@ -219,8 +219,8 @@ begin
         return NEW;
     end if;
 
-    raise exception '[403] insert into hs_office_partner not allowed for current subjects % (%)',
-            currentSubjects(), currentSubjectsUuids();
+    raise exception '[403] insert into hs_office_partner values(%) not allowed for current subjects % (%)',
+            NEW, currentSubjects(), currentSubjectsUuids();
 end; $$;
 
 create trigger hs_office_partner_insert_permission_check_tg

src/main/resources/db/changelog/5-hs-office/504-partner/5044-hs-office-partner-details-rbac.sql

@@ -123,8 +123,8 @@ begin
         return NEW;
     end if;
 
-    raise exception '[403] insert into hs_office_partner_details not allowed for current subjects % (%)',
-            currentSubjects(), currentSubjectsUuids();
+    raise exception '[403] insert into hs_office_partner_details values(%) not allowed for current subjects % (%)',
+            NEW, currentSubjects(), currentSubjectsUuids();
 end; $$;
 
 create trigger hs_office_partner_details_insert_permission_check_tg

src/main/resources/db/changelog/5-hs-office/506-debitor/5063-hs-office-debitor-rbac.sql

@@ -192,8 +192,8 @@ begin
         return NEW;
     end if;
 
-    raise exception '[403] insert into hs_office_debitor not allowed for current subjects % (%)',
-            currentSubjects(), currentSubjectsUuids();
+    raise exception '[403] insert into hs_office_debitor values(%) not allowed for current subjects % (%)',
+            NEW, currentSubjects(), currentSubjectsUuids();
 end; $$;
 
 create trigger hs_office_debitor_insert_permission_check_tg

src/main/resources/db/changelog/5-hs-office/507-sepamandate/5073-hs-office-sepamandate-rbac.sql

@@ -173,8 +173,8 @@ begin
         return NEW;
     end if;
 
-    raise exception '[403] insert into hs_office_sepamandate not allowed for current subjects % (%)',
-            currentSubjects(), currentSubjectsUuids();
+    raise exception '[403] insert into hs_office_sepamandate values(%) not allowed for current subjects % (%)',
+            NEW, currentSubjects(), currentSubjectsUuids();
 end; $$;
 
 create trigger hs_office_sepamandate_insert_permission_check_tg

src/main/resources/db/changelog/5-hs-office/510-membership/5103-hs-office-membership-rbac.sql

@@ -154,8 +154,8 @@ begin
         return NEW;
     end if;
 
-    raise exception '[403] insert into hs_office_membership not allowed for current subjects % (%)',
-            currentSubjects(), currentSubjectsUuids();
+    raise exception '[403] insert into hs_office_membership values(%) not allowed for current subjects % (%)',
+            NEW, currentSubjects(), currentSubjectsUuids();
 end; $$;
 
 create trigger hs_office_membership_insert_permission_check_tg

src/main/resources/db/changelog/5-hs-office/511-coopshares/5113-hs-office-coopshares-rbac.sql

@@ -130,8 +130,8 @@ begin
         return NEW;
     end if;
 
-    raise exception '[403] insert into hs_office_coopsharestransaction not allowed for current subjects % (%)',
-            currentSubjects(), currentSubjectsUuids();
+    raise exception '[403] insert into hs_office_coopsharestransaction values(%) not allowed for current subjects % (%)',
+            NEW, currentSubjects(), currentSubjectsUuids();
 end; $$;
 
 create trigger hs_office_coopsharestransaction_insert_permission_check_tg

src/main/resources/db/changelog/5-hs-office/512-coopassets/5123-hs-office-coopassets-rbac.sql

@@ -130,8 +130,8 @@ begin
         return NEW;
     end if;
 
-    raise exception '[403] insert into hs_office_coopassetstransaction not allowed for current subjects % (%)',
-            currentSubjects(), currentSubjectsUuids();
+    raise exception '[403] insert into hs_office_coopassetstransaction values(%) not allowed for current subjects % (%)',
+            NEW, currentSubjects(), currentSubjectsUuids();
 end; $$;
 
 create trigger hs_office_coopassetstransaction_insert_permission_check_tg