hostsharing/hs.hsadmin.ng
1
0
Fork 0
Code Activity

cleanup+categorization of TODOs

Browse Source
This commit is contained in:
Michael Hoennig
2022-09-07 12:25:12 +02:00
parent 756d5e1ae6
commit 23796c56f9
14 changed files with 26 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/main/java/net/hostsharing/hsadminng/context/Context.java
View File

@ -63,7 +63,7 @@ public class Context {
cast(:assumedRoles as varchar));
""");
query.setParameter("currentTask", shortenToMaxLength(currentTask, 96));
query.setParameter("currentRequest", shortenToMaxLength(currentRequest, 512)); // TODO.SPEC: length?
query.setParameter("currentRequest", shortenToMaxLength(currentRequest, 512)); // TODO.spec: length?
query.setParameter("currentUser", currentUser);
query.setParameter("assumedRoles", assumedRoles != null ? assumedRoles : "");
query.executeUpdate();
@ -91,7 +91,7 @@ public class Context {
public UUID[] currentSubjectsUuids() {
return (UUID[]) em.createNativeQuery("select currentSubjectsUuids() as uuids")
.unwrap(org.hibernate.query.NativeQuery.class)
.addScalar("uuids", UUIDArrayType.INSTANCE) // TODO.BLOG
.addScalar("uuids", UUIDArrayType.INSTANCE) // TODO.blog
.getSingleResult();
}

2
src/main/java/net/hostsharing/hsadminng/hs/admin/contact/HsAdminContactRepository.java
View File

@ -16,7 +16,7 @@ public interface HsAdminContactRepository extends Repository<HsAdminContactEntit
WHERE :label is null
OR c.label like concat(:label, '%')
""")
// TODO: join tables missing
// TODO.feat: join tables missing
List<HsAdminContactEntity> findContactByOptionalLabelLike(String label);
HsAdminContactEntity save(final HsAdminContactEntity entity);

12
src/main/java/net/hostsharing/hsadminng/hs/admin/partner/HsAdminPartnerController.java
View File

@ -37,9 +37,9 @@ public class HsAdminPartnerController implements HsAdminPartnersApi {
final String currentUser,
final String assumedRoles,
final String name) {
// TODO: context.define(currentUser, assumedRoles);
// TODO.feat: context.define(currentUser, assumedRoles);
// TODO: final var entities = partnerRepo.findPartnerByOptionalNameLike(name);
// TODO.feat: final var entities = partnerRepo.findPartnerByOptionalNameLike(name);
final var entities = List.of(
HsAdminPartnerEntity.builder()
@ -83,13 +83,13 @@ public class HsAdminPartnerController implements HsAdminPartnersApi {
final String assumedRoles,
final HsAdminPartnerResource body) {
// TODO: context.define(currentUser, assumedRoles);
// TODO.feat: context.define(currentUser, assumedRoles);
if (body.getUuid() == null) {
body.setUuid(UUID.randomUUID());
}
// TODO: final var saved = partnerRepo.save(map(body, HsAdminPartnerEntity.class));
// TODO.feat: final var saved = partnerRepo.save(map(body, HsAdminPartnerEntity.class));
final var saved = map(body, HsAdminPartnerEntity.class, PARTNER_RESOURCE_TO_ENTITY_POSTMAPPER);
final var uri =
@ -108,9 +108,9 @@ public class HsAdminPartnerController implements HsAdminPartnersApi {
final String assumedRoles,
final UUID partnerUuid) {
// TODO: context.define(currentUser, assumedRoles);
// TODO.feat: context.define(currentUser, assumedRoles);
// TODO: final var result = partnerRepo.findByUuid(partnerUuid);
// TODO.feat: final var result = partnerRepo.findByUuid(partnerUuid);
final var result =
partnerUuid.equals(UUID.fromString("3fa85f64-5717-4562-b3fc-2c963f66afa6")) ? null :
HsAdminPartnerEntity.builder()