add API validation

src/test/java/net/hostsharing/hsadminng/errors/RestResponseEntityExceptionHandlerUnitTest.java

@@ -5,16 +5,24 @@ import org.junit.jupiter.api.extension.ExtendWith;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.ValueSource;
 import org.mockito.junit.jupiter.MockitoExtension;
+import org.springframework.core.MethodParameter;
 import org.springframework.dao.DataIntegrityViolationException;
+import org.springframework.http.HttpHeaders;
+import org.springframework.http.HttpStatus;
 import org.springframework.orm.jpa.JpaObjectRetrievalFailureException;
 import org.springframework.orm.jpa.JpaSystemException;
+import org.springframework.validation.BindingResult;
+import org.springframework.validation.FieldError;
+import org.springframework.web.bind.MethodArgumentNotValidException;
 import org.springframework.web.context.request.WebRequest;
 
 import javax.persistence.EntityNotFoundException;
+import java.util.List;
 import java.util.NoSuchElementException;
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
 
 @ExtendWith(MockitoExtension.class)
 class RestResponseEntityExceptionHandlerUnitTest {
@@ -167,6 +175,32 @@ class RestResponseEntityExceptionHandlerUnitTest {
         assertThat(errorResponse.getBody().getMessage()).isEqualTo("given error message");
     }
 
+    @Test
+    void handleMethodArgumentNotValidException() {
+        // given
+        final var givenBindingResult = mock(BindingResult.class);
+        when(givenBindingResult.getFieldErrors()).thenReturn(List.of(
+                new FieldError("someObject", "someField", "someRejectedValue", false, null, null, "expected to be something")
+        ));
+        final var givenException = new MethodArgumentNotValidException(
+                mock(MethodParameter.class),
+                givenBindingResult
+
+        );
+        final var givenWebRequest = mock(WebRequest.class);
+
+        // when
+        final var errorResponse = exceptionHandler.handleMethodArgumentNotValid(givenException,
+                HttpHeaders.EMPTY, HttpStatus.BAD_REQUEST, givenWebRequest);
+
+        // then
+        assertThat(errorResponse.getStatusCodeValue()).isEqualTo(400);
+        assertThat(errorResponse.getBody())
+                .isInstanceOf(CustomErrorResponse.class)
+                .extracting("message")
+                .isEqualTo("[someField expected to be something but is \"someRejectedValue\"]");
+    }
+
     @Test
     void handleOtherExceptionsWithoutErrorCode() {
         // given
@@ -195,6 +229,20 @@ class RestResponseEntityExceptionHandlerUnitTest {
         assertThat(errorResponse.getBody().getMessage()).isEqualTo("ERROR: [418] First Line");
     }
 
+    @Test
+    void handleOtherExceptionsWithoutMessage() {
+        // given
+        final var givenThrowable = new Error();
+        final var givenWebRequest = mock(WebRequest.class);
+
+        // when
+        final var errorResponse = exceptionHandler.handleOtherExceptions(givenThrowable, givenWebRequest);
+
+        // then
+        assertThat(errorResponse.getStatusCodeValue()).isEqualTo(500);
+        assertThat(errorResponse.getBody().getMessage()).isEqualTo("ERROR: [500] java.lang.Error");
+    }
+
     public static class NoDisplayNameEntity {
 
     }

src/test/java/net/hostsharing/hsadminng/hs/office/debitor/HsOfficeDebitorControllerAcceptanceTest.java

@@ -26,8 +26,7 @@ import static net.hostsharing.test.IsValidUuidMatcher.isUuidValid;
 import static net.hostsharing.test.JsonMatcher.lenientlyEquals;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assumptions.assumeThat;
-import static org.hamcrest.Matchers.is;
-import static org.hamcrest.Matchers.startsWith;
+import static org.hamcrest.Matchers.*;
 
 @SpringBootTest(
         webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT,
@@ -190,36 +189,36 @@ class HsOfficeDebitorControllerAcceptanceTest {
         }
 
         @Test
-        void globalAdmin_withoutAssumedRole_canAddDebitorWithoutBankAccount() {
+        void globalAdmin_canAddDebitorWithoutJustRequiredData() {
 
             context.define("superuser-alex@hostsharing.net");
             final var givenPartner = partnerRepo.findPartnerByOptionalNameLike("Third").get(0);
             final var givenContact = contactRepo.findContactByOptionalLabelLike("forth").get(0);
 
             final var location = RestAssured // @formatter:off
-                    .given()
+                .given()
                     .header("current-user", "superuser-alex@hostsharing.net")
                     .contentType(ContentType.JSON)
                     .body("""
                                {
                                    "partnerUuid": "%s",
                                    "billingContactUuid": "%s",
-                                   "debitorNumber": "%s",
-                                   "vatId": "VAT123456",
-                                   "vatCountryCode": "DE",
-                                   "vatBusiness": true
+                                   "debitorNumber": "%s"
                                  }
                             """.formatted( givenPartner.getUuid(), givenContact.getUuid(), nextDebitorNumber++))
                     .port(port)
-                    .when()
+                .when()
                     .post("http://localhost/api/hs/office/debitors")
-                    .then().log().all().assertThat()
+                .then().log().all().assertThat()
                     .statusCode(201)
                     .contentType(ContentType.JSON)
                     .body("uuid", isUuidValid())
-                    .body("vatId", is("VAT123456"))
                     .body("billingContact.label", is(givenContact.getLabel()))
                     .body("partner.person.tradeName", is(givenPartner.getPerson().getTradeName()))
+                    .body("vatId", equalTo(null))
+                    .body("vatCountryCode", equalTo(null))
+                    .body("vatBusiness", equalTo(false))
+                    .body("refundBankAccount", equalTo(null))
                     .header("Location", startsWith("http://localhost"))
                     .extract().header("Location");  // @formatter:on