hostsharing/hs.hsadmin.ng
1
0
Fork 0
Code Activity

improved shouldValidateThatUntilDateIsAfterSinceDate test

Browse Source
This commit is contained in:
Michael Hoennig
2019-04-11 18:16:08 +02:00
parent d1d6001842
commit ca9879db92
1 changed files with 27 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
src/test/java/org/hostsharing/hsadminng/service/MembershipValidatorUnitTest.java
View File

@@ -27,17 +27,40 @@ public class MembershipValidatorUnitTest {
private MembershipValidator membershipValidator; private MembershipValidator membershipValidator;
@Test @Test
public void shouldRejectIfUntilDateIsNotAfterSinceDate() { public void shouldValidateThatUntilDateIsAfterSinceDate() {
// JUnit 4 parameterized tests are quite ugly, that's why I do it this way
shouldAcceptValidUntilDate("2019-04-10", "2019-04-11");
shouldRejectInvalidUntilDate("2019-04-11", "2019-04-11");
shouldRejectInvalidUntilDate("2019-04-12", "2019-04-11");
}
private void shouldAcceptValidUntilDate(final String sinceDate, final String untilDate) {
// given // given
final MembershipDTO membershipDTO = new MembershipDTO(); final MembershipDTO membershipDTO = new MembershipDTO();
membershipDTO.setSinceDate(LocalDate.parse("2019-04-11")); membershipDTO.setSinceDate(LocalDate.parse(sinceDate));
membershipDTO.setUntilDate(LocalDate.parse("2019-04-11")); membershipDTO.setUntilDate(LocalDate.parse(untilDate));
// when
final Throwable throwException = catchThrowableOfType(() -> membershipValidator.validate(membershipDTO), Throwable.class);
// then
assertThat(throwException).isNull();
}
private void shouldRejectInvalidUntilDate(final String sinceDate, final String untilDate) {
// given
final MembershipDTO membershipDTO = new MembershipDTO();
membershipDTO.setSinceDate(LocalDate.parse(sinceDate));
membershipDTO.setUntilDate(LocalDate.parse(untilDate));
// when // when
final Throwable throwException = catchThrowableOfType(() -> membershipValidator.validate(membershipDTO), BadRequestAlertException.class); final Throwable throwException = catchThrowableOfType(() -> membershipValidator.validate(membershipDTO), BadRequestAlertException.class);
// then // then
assertThat(throwException).isNotNull(); assertThat(throwException).isNotNull();
} }
} }